Merged
Conversation
Co-authored-by: ashiven <nevisha@pm.me> Signed-off-by: SirGankalot <73303677+SirGankalot@users.noreply.github.com>
Author
|
Merge only possible after Issue-e-m-b-a#85 is merged. (the base branch is Issue-e-m-b-a#85 -> from @ashiven) |
Signed-off-by: ashiven <nevisha@pm.me>
Signed-off-by: ashiven <nevisha@pm.me>
Signed-off-by: ashiven <nevisha@pm.me>
|
@LukaDeka The only actual change in this issue is the worker soft reset function. Sorry for all the other commits that showed up from merging main into this branch |
It's probably some bug of GitHub that can be fixed by changing and readding back the base of the merge request. |
LukaDeka
requested changes
Jul 16, 2025
LukaDeka
left a comment
LukaDeka
left a comment
There was a problem hiding this comment.
A few nitpicks that could be addressed.
I'll merge this until the deadline if they're not addressed because I think it's fine otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
Firmware analysis is not switched to a diffrent worker for softreset
What is the new behavior (if this is a feature change)? If possible add a screenshot.
Firmware analysis is switched to a diffrent worker for softreset
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No